add simple provider #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anvddriesch
commented
Nov 27, 2023
|
|
||
| func usesRedirectURI(connectorType string) bool { | ||
| switch connectorType { | ||
| case "ldap", "authproxy", "atlassian-crowd", "keystone": |
There was a problem hiding this comment.
These types do not use callback so it would cause an error to inject redirectURI.
| @@ -197,6 +198,16 @@ func getProvidersFromConfig(credentials Config, include string, log logr.Logger) | |||
| return providers, nil | |||
| } | |||
|
|
|||
| func includeProvider(include string, provider string) bool { | |||
| if provider == simpleprovider.ProviderName { | |||
| return false | |||
There was a problem hiding this comment.
The simple type does not allow access to the idp and therefore can not create a new credential. It needs to be set up manually.
When updating credentials however, the old one will be kept.
|
I'm fine with the code, but it would be good to add some documentation. You forgot to add "if one credential leaks then all clusters are compromised" to the list of benefits :P |
|
@kopiczko I added some documentation with stronger mention of the implications. |
kopiczko
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards giantswarm/roadmap#2988
This adds the simple provider to dex operator.
The provider works by simply copying existing connector data to dex-apps across an MC and injecting the callback URIs.
It has the following benefits