add unit tests #44
Draft
add unit tests #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuantumEnigmaa
force-pushed
the
add-unit-tests
branch
from
6ceca40 to
d1a58db
Compare
QuantumEnigmaa
force-pushed
the
add-unit-tests
branch
from
b38cfe9 to
61df9ae
Compare
QuantumEnigmaa
force-pushed
the
add-unit-tests
branch
from
ff8b08d to
eae7221
Compare
|
|
||
| // Reconciler creation | ||
| var mgr manager.Manager | ||
| Eventually(func() error { |
There was a problem hiding this comment.
I think the idea is that we do not use a manager in tests
| } | ||
|
|
||
| loggingReconciler := loggingreconciler.LoggingReconciler{ | ||
| Client: mgr.GetClient(), |
There was a problem hiding this comment.
You'd replace the getClient by te k8sClient
|
|
||
| promtailReconciler := promtailtoggle.Reconciler{ | ||
| Client: mgr.GetClient(), | ||
| Scheme: mgr.GetScheme(), |
There was a problem hiding this comment.
And we probably do not even need a scheme here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards https://github.com/giantswarm/giantswarm/issues/28196