Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dnsmasq as extraContainer to loki-gateway #238

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Add dnsmasq as extraContainer to loki-gateway #238

merged 3 commits into from
Nov 17, 2023

Conversation

marieroque
Copy link
Contributor

@marieroque marieroque requested a review from a team as a code owner November 15, 2023 10:47
@marieroque
Copy link
Contributor Author

marieroque commented Nov 15, 2023 •
edited
Loading

⚠️ WAIT FOR MERGE:
Asked opinion to @giantswarm/team-cabbage about the fix and potential side effects

@QuentinBisson
Copy link
Contributor

Maybe ask on slack ?

@mcharriere
Copy link

mcharriere commented Nov 16, 2023 •
edited
Loading

hi there. I don't see any problem with this; but I'm a bit skeptical about the end result.

The issue manifests after the coredns pods backing the kube-dns service are restarted

NGINX doesn't talk directly to coredns; as we run k8s-dns-local-cache on each node. It's even more unlikely that the local cache gets restarted (without the entire node going down)
OK. ignore me. you are running this on the MC, right?

Based on that, it's totally plausible. dnsmasq will help.

@marieroque marieroque marked this pull request as draft November 16, 2023 13:20
@marieroque marieroque changed the title Add dnsmasq as extraContainer to loki-gateway Add CiliumNetworkPolicy to loki-gateway to enable DNS Cache Nov 16, 2023
@marieroque marieroque force-pushed the add-dnsmasq-to-gateway branch from 3b6b9e1 to ddb1ec7 Compare November 17, 2023 08:19
@marieroque marieroque marked this pull request as ready for review November 17, 2023 08:19
@marieroque marieroque changed the title Add CiliumNetworkPolicy to loki-gateway to enable DNS Cache Add dnsmasq as extraContainer to loki-gateway Nov 17, 2023
@marieroque marieroque merged commit ef3e192 into master Nov 17, 2023
6 checks passed
@marieroque marieroque deleted the add-dnsmasq-to-gateway branch November 17, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuentinBisson QuentinBisson QuentinBisson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marieroque @QuentinBisson @mcharriere