add automated tests for the chart #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuantumEnigmaa
force-pushed
the
add-automated-tests
branch
from
4fa15fa to
5e62043
Compare
QuantumEnigmaa
force-pushed
the
add-automated-tests
branch
from
5e62043 to
97c23b0
Compare
QuantumEnigmaa
force-pushed
the
add-automated-tests
branch
from
b8ca808 to
3642e43
Compare
QuantumEnigmaa
force-pushed
the
add-automated-tests
branch
from
5eb1e4f to
0a13a58
Compare
QuantumEnigmaa
force-pushed
the
add-automated-tests
branch
from
cb5fc17 to
c2a4476
Compare
|
It's finally working ! |
QuantumEnigmaa
force-pushed
the
add-automated-tests
branch
from
c0aa55a to
28bd814
Compare
|
It would be good to have the values file somehow in sync with what we have in production. |
hervenicol
reviewed
Sep 3, 2024
hervenicol
reviewed
Sep 3, 2024
|
In addition to what was suggested, I also disabled the loki-multi-tenant-proxy as well as the ingress to match this : https://github.com/giantswarm/shared-configs/pull/147/files |
The test-values I use is as close as it can be from a production loki as it's basically grizzly's chart-values tuned just enough to make it work in the ATS environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards giantswarm/roadmap#2008