Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for canary deployment #365

Merged
merged 1 commit into from
Sep 24, 2024
Merged

add support for canary deployment #365

merged 1 commit into from
Sep 24, 2024

Conversation

hervenicol
Copy link
Contributor

Towards https://github.com/giantswarm/giantswarm/issues/28584

As upstream PR for deploying canary as a deployment (grafana/loki#13362) is not moving forward, let's implement it in our chart.

@hervenicol hervenicol self-assigned this Sep 23, 2024
@hervenicol hervenicol force-pushed the loki-canary branch 2 times, most recently from 46a484b to a33c4fc Compare September 23, 2024 15:46
@hervenicol
Copy link
Contributor Author

Tested on golem with these values:

lokiCanary:
  enabled: true
  extraArgs:
    - "-tenant-id=golem"

3 canary pods running, and generating metrics.
image

It shows 33% errors, but I can't figure out why.

@hervenicol
Copy link
Contributor Author

Well, the dashboard looks crappy, but the canary works. 🤷

@hervenicol hervenicol marked this pull request as ready for review September 24, 2024 07:54
@hervenicol hervenicol requested a review from a team as a code owner September 24, 2024 07:54
@QuentinBisson
Copy link
Contributor

Did you figure out why you had 33% of errors?

@QuentinBisson
Copy link
Contributor

If the dashboard is shit, we can most likely improve it upstream :)

@hervenicol
Copy link
Contributor Author

Did you figure out why you had 33% of errors?

Well, 33% was an optimistic (and possible) value.
Currently it clearly shows nonsense 🤣
image

But yes, I hope to investigate and fix the dashboard later, and hopefully upstream.

@hervenicol hervenicol merged commit 5bab143 into main Sep 24, 2024
7 checks passed
@hervenicol hervenicol deleted the loki-canary branch September 24, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants