-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up continuous integration #5
base: master
Are you sure you want to change the base?
Conversation
Hi both, I have doubts about the docker images tags : during setup job we tag the new image with the current branch name, while we pull the "master" docker image during test job, is it an expected behavior? I also read some warnings about using the dind service, I pursue my investigations and leave two interesting links : https://jpetazzo.github.io/2015/09/03/do-not-use-docker-in-docker-for-ci/ |
DEBIAN_FRONTEND=noninteractive apt-get install -y \ | ||
tzdata \ | ||
git-core \ | ||
python3.7 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be specifying version numbers here to ensure that subsequent builds are the same - the only problem is that these versions aren't available indefinitely from the apt repositories, causing failed builds later on.
I'm not sure what the best solution is for this - I think for now it's okay, but in the future if we were to be more strict then we may have to come up with a more permanent (non trivial!) solution
Hi Francois, Good point regarding your concern with our tags - I think we could change Regarding DIND, it's certainly not an ideal solution, or one that I'd like to use if we were doing anything complicated but it's Gitlab's recommended method. It does have the drawback of not making use of the Docker cache which would speed up builds. Perhaps we could look at running them directly on Gift-Little instead? I think that would take some re-configuring of the CI runner but could be done. |
The built and used Docker image paths are now identical. |
Closes #2