Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package and module structure #7

Merged
merged 17 commits into from
Oct 17, 2019
Merged

Conversation

dzhoshkun
Copy link
Contributor

@dzhoshkun dzhoshkun commented Sep 9, 2019

Closes #6

@dzhoshkun dzhoshkun added the wip - do not merge Worn In Progress -- do not merge label Sep 9, 2019
@dzhoshkun dzhoshkun changed the title [WIP] Add package and module structure Add package and module structure Sep 13, 2019
@dzhoshkun dzhoshkun removed the wip - do not merge Worn In Progress -- do not merge label Sep 13, 2019
@dzhoshkun dzhoshkun changed the base branch from 1-prepare-front-page to master September 13, 2019 14:32
@dzhoshkun dzhoshkun requested a review from tvercaut September 13, 2019 14:33
@dzhoshkun dzhoshkun requested a review from ericspod September 27, 2019 11:25
Copy link
Collaborator

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I think the architecture is structured fine with a good division between the manager and worker components. I have said in a few places that code can be made to generically handle either threads or processes using shim types and the fact that the multiprocessing primitives (lock, pip, queue, shared memory, etc.) work just fine with threads so using them everywhere doesn't hurt. I had written a bit about the buffer definition that you have and would suggest rethinking this after reviewing how Queue works and also looking into using the Pipe primitive directly. Shoving huge amounts of data down queues or pipes isn't a great idea so consider using shared memory for that.

puma/buffer/README.md Show resolved Hide resolved
puma/buffer/README.md Show resolved Hide resolved
puma/buffer/README.md Outdated Show resolved Hide resolved
puma/buffer/README.md Outdated Show resolved Hide resolved
puma/buffer/README.md Show resolved Hide resolved
puma/context/README.md Show resolved Hide resolved
puma/environment/README.md Show resolved Hide resolved
puma/environment/README.md Show resolved Hide resolved
puma/runner/README.md Show resolved Hide resolved
puma/buffer/README.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outline package and module hierarchy
2 participants