Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ajout de descriptions des champs service #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Caldagues
Copy link
Contributor

Ajout de desc pour quasiment tous les champs

Ajout de desc pour quasiment tous les champs
@Caldagues Caldagues requested a review from vmttn June 12, 2024 16:24
@vmttn vmttn changed the title Update services.py feat: ajout de descriptions pour les champs service Jul 17, 2024
@vmttn vmttn changed the title feat: ajout de descriptions pour les champs service feat: ajout de descriptions des champs service Jul 18, 2024
Copy link
Contributor

@vmttn vmttn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bon ça va prendre un peu de temps ;) première passe très partielle

src/data_inclusion/schema/services.py Show resolved Hide resolved
src/data_inclusion/schema/services.py Show resolved Hide resolved
src/data_inclusion/schema/services.py Show resolved Hide resolved
src/data_inclusion/schema/services.py Show resolved Hide resolved
Comment on lines +108 to +118
prise_rdv: Annoted[
Optional[HttpUrl],
Field(
description="""
Lien vers une page web permettant la prise de rendez-vous pour l'offre de service.
""",
examples=[
"https://centresocialduroussillonnais.fr/services-aux-habitants/prendre-rendez-vous-avec-un-cnfs/"
],
),
] = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il faudrait plutot un lien vers rendez-vous solidarité

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Par ailleurs on devrait préciser : c'est un lien vers un outil de prise de rendez-vous

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je pensais que c'était sur un outil en ligne fourni par le producteur et non toujours rdv solidarité. Mais ça doit très peu arriver que le producteur ait une url de rdv et sinon il peut toujours utiliser formulaire_en_ligne

src/data_inclusion/schema/services.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants