This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
API v2 ServiceSerializer: on ne filtre plus les sous-catégories --autre #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbuget
added a commit
that referenced
this pull request
Oct 9, 2024
### 🍣 Contexte / problème La PR #392 modifie les données envoyées par DORA à DI via l'API. Nous nous sommes mal synchronisés / organisés entre les 2 équipes. Nous avons envoyé la modif alors que DI n'a pas fait la leur de leur côté. Ça génère des erreurs et des services qui ne sont pas remontés dans DI. ### 🦄 Solution Le temps de permettre à DI de faire le fix, nous proposons de rollback la modif. ### 🍿 Misc This reverts commit ec4653e.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DI fait dorénavant lui-même la transformation. On ne filtre donc plus les sous-catégories se terminant par
--autre.Le test de ce filtrage a été supprimé.
https://trello.com/c/aLeDF7Gj/199-di-x-dora-api-ne-renvoi-pas-les-th%C3%A9matiques-dun-service#comment-66f513ee9701b3ba18cf1193