-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recherche de structures par le nom pour les admins et managers #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lisateur est staff ou manager
jbuget
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Déjà validé, avec quelques nitpicks (d'où le besoin de revalider)
LGTM 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ PR créée à partir de la PR originale gip-inclusion/dora-front#458 suite à la création du monorepo.
Dépendance back : gip-inclusion/dora-back#397
Problème : la création d'un service depuis un modèle cause un appel au point d'API /structures/ qui liste toutes les structures de la base lorsqu'on est admin. La taille de la réponse atteint 5 Mo et provoque un gros ralentissement voire un plantage de la page.
Solution : ajout d'un paramètre de recherche textuel sur le nom de la structure pour limiter le nombre de résultats. Le front l'utilise avec 3 caractères minimum.
Changements :
getManagedStructure()
: ajout d'un paramètre de recherche textuel et utilisation du paramètresearch
du endpoint ;FieldsStructure
: utilisation d'une fonction de recherche ;