Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the /updpkgsums slash command #54

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

dscho
Copy link
Member

@dscho dscho commented Dec 17, 2023

Marked as draft because it needs git-for-windows/git-for-windows-automation#62 to be merged first.

As with most of the other slash commands, this triggers a GitHub workflow run in git-for-windows-automation, in this instance, unsurprisingly the upkpkgsums.yml one.

The idea is to help contributors with their Pull Requests that fail CI builds solely due to mismatched checksums after modifying, adding or removing files from a package.

This fixes #28.

As with most of the other slash commands, this triggers a GitHub
workflow run in `git-for-windows-automation`, in this instance,
unsurprisingly the `upkpkgsums.yml` one.

The idea is to help contributors with their Pull Requests that fail CI
builds solely due to mismatched checksums after modifying, adding or
removing files from a package.

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho self-assigned this Dec 17, 2023
@dscho dscho marked this pull request as ready for review December 18, 2023 12:56
@dscho dscho requested a review from rimrul December 18, 2023 12:56
@@ -105,6 +105,35 @@ module.exports = async (context, req) => {
return `I edited the comment: ${commentURL}`
}

if (command == '/updpkgsums') {
if (owner !== 'git-for-windows'
|| !req.body.issue.pull_request
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should move the requirement to be issued from a PR to its own error mesage, here and in other slash commands at some point in the future.

#leftoverbits

@dscho dscho merged commit cf0591c into git-for-windows:main Dec 18, 2023
1 check passed
@dscho dscho deleted the updpkgsums branch December 18, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an /updpkgsums command
2 participants