Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor assembly language detection #7229

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

donno2048
Copy link
Contributor

@donno2048 donno2048 commented Feb 1, 2025

Pretty much refactor the entire assembly language detection

Checklist:

  • I am adding a new extension to a language.
    • The new extension is used in hundreds of repositories on GitHub.com
    • I have included a real-world usage sample for all extensions added in this PR:
      • Sample source(s):
      • Sample license(s): it's code I wrote just because literally every .asm file could serve the same purpose as a .s and that's the first that came to my mind... You can use it however you want as long as you don't pretend you wrote it...
    • I have included a change to the heuristics to distinguish my language from others using the same extension.

@donno2048 donno2048 requested a review from a team as a code owner February 1, 2025 17:40
@donno2048 donno2048 marked this pull request as draft February 1, 2025 17:40
@donno2048 donno2048 marked this pull request as ready for review February 1, 2025 18:29
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment.

lib/linguist/heuristics.yml Outdated Show resolved Hide resolved
@donno2048
Copy link
Contributor Author

@lildude fixed

@donno2048 donno2048 changed the title Add .s extension to Assembly language Refactor assembly language detection Feb 4, 2025
@donno2048
Copy link
Contributor Author

I'll delete Assembly/audio.i and Assembly/macros.inc as they both are not nasm assembly so will create false-negative

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants