Improved Messaging #332
Merged
Improved Messaging #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…through to the `post-deploy-message()` function so that is available as a template variable for deployment messages
…template variables
…ssages: `params`, `parsed_params`, `fork`
|
Testing this out so far and the deployment messages (a custom one) has a lot more details:
|
…ribute for deployment messages
…sers want to attempt to parse issue comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request greatly improves the messaging system of this Action which is ultimately the text that humans read on PRs that they deploy.
The primary changes are as follows:
sha- The sha of the deployment (String)review_decision- The review status of the pull request (String or null) - Ex:APPROVED,REVIEW_REQUIRED,CHANGES_REQUESTED,nulletc.deployment_id- The ID of the deployment (Int or null in the case of.noopdeployments)fork- Whether or not the repository is a fork (Boolean)params- The raw string of deployment parameters (String)parsed_params- A string representation of the parsed deployment parameters (String)deployment_end_time- The time the deployment ended - this value is not exact but it is very close (String) ISO 8601 UTC formatlogs- The URL to the logs of the deployment (String)Updated Pre Deploy Messages
Pre-deploy (initial kick-off messages) will now have a
Detailssection that is expandable and contains rich data about the deployment that is soon to be created. Example:Updated Post Deploy Messages
Post-deploy messages will also have a new
Detailssection that is expandable and contains rich data about the deployment that has just completed.