General Fixes + More Logging #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 7 out of 9 changed files in this pull request and generated no suggestions.
Files not reviewed (2)
- script/release: Language not supported
- tests/version.test.js: Evaluated as low risk
Comments skipped due to low confidence (1)
src/functions/prechecks.js:137
- The 'reviews' field is being queried twice in the GraphQL query, which is redundant and could lead to unnecessary data fetching. The first occurrence should be removed.
reviews(states: APPROVED) {
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request touches up a few places of the code base to make it a bit cleaner and improves logging.
This PR also introduces a new
VERSIONconstant into the project that will be displayed in logs, and used in the release process.