-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main into releases/v3 #2739
Conversation
Mergeback v3.28.6 refs/heads/releases/v3 into main
start-proxy: Remove unusued proxy_password input
start-proxy: Skip proxy setup if no credentials are available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
start-proxy/action.yml:10
- The removal of the proxy_password input is a user-facing change that is not documented. If you intend to remove it, please update the changelog accordingly; otherwise, restore the input.
proxy_password:
Tip: Leave feedback on Copilot's review comments with the 👎 and 👍 buttons to help improve review quality. Learn more
No user facing changes. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the proxy_password input is a user-facing change, so this line is misleading. Please update the changelog to reflect the removal of the proxy_password input or revert its removal if it was unintentional.
No user facing changes. | |
- Removed the `proxy_password` input. [#XXXX](https://github.com/github/codeql-action/pull/XXXX) |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Merging 54b1c84 into
releases/v3
.Conductor for this PR is @marcogario.
Contains the following pull requests:
Please do the following:
releases/v3
branch.Create a merge commit
is selected rather thanSquash and merge
orRebase and merge
.