Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into releases/v3 #2739

Closed
wants to merge 10 commits into from
Closed

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 29, 2025

Merging 54b1c84 into releases/v3.

Conductor for this PR is @marcogario.

Contains the following pull requests:

Please do the following:

  • Ensure the CHANGELOG displays the correct version and date.
  • Ensure the CHANGELOG includes all relevant, user-facing changes since the last release.
  • Check that there are not any unexpected commits being merged into the releases/v3 branch.
  • Ensure the docs team is aware of any documentation changes that need to be released.
  • Mark the PR as ready for review to trigger the full set of PR checks.
  • Approve and merge this PR. Make sure Create a merge commit is selected rather than Squash and merge or Rebase and merge.
  • Merge the mergeback PR that will automatically be created once this PR is merged.
  • Merge all backport PRs to older release branches, that will automatically be created once this PR is merged.

@marcogario marcogario marked this pull request as ready for review January 29, 2025 08:22
@Copilot Copilot bot review requested due to automatic review settings January 29, 2025 08:22
@marcogario marcogario requested a review from a team as a code owner January 29, 2025 08:22
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

start-proxy/action.yml:10

  • The removal of the proxy_password input is a user-facing change that is not documented. If you intend to remove it, please update the changelog accordingly; otherwise, restore the input.
  proxy_password:

Tip: Leave feedback on Copilot's review comments with the 👎 and 👍 buttons to help improve review quality. Learn more

Comment on lines +7 to +8
No user facing changes.

Copy link
Preview

Copilot AI Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the proxy_password input is a user-facing change, so this line is misleading. Please update the changelog to reflect the removal of the proxy_password input or revert its removal if it was unintentional.

Suggested change
No user facing changes.
- Removed the `proxy_password` input. [#XXXX](https://github.com/github/codeql-action/pull/XXXX)

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@marcogario marcogario marked this pull request as draft January 29, 2025 08:24
@marcogario marcogario closed this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants