Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mention of steps from concurrency description #36084

Merged
merged 5 commits into from
Jan 29, 2025
Merged

Remove mention of steps from concurrency description #36084

merged 5 commits into from
Jan 29, 2025

Conversation

mil-dot
Copy link
Contributor

@mil-dot mil-dot commented Jan 28, 2025 •
edited
Loading

Concurrency group can be defined either on a workflow level or on a job level. Steps should not be mentioned because it's not possible to control concurrency on a job step level.

Why:

Closes: ISSUE_NUMBER

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the preview environment.

@mil-dot
Remove mention of steps from concurrency description
2eb1442 
Concurrency group can be defined either on a workflow level or on a job level. Steps should not be mentioned because it's not possible to control concurrency on a job step level.
@welcome Welcome
Copy link

welcome bot commented Jan 28, 2025

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

👓 Previews for changed content

This comment is 🤖 automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the review server. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server
This table is posted from the Content Changes Table Comment workflow.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jan 28, 2025
@mil-dot mil-dot marked this pull request as ready for review January 28, 2025 21:53
BREYES2024

This comment was marked as spam.

Sign in to view

@mil-dot
Copy link
Contributor Author

mil-dot commented Jan 29, 2025

Please see carefully the change, over all file with us extention...

Could you please specify what to look for? I've checked the whole page for the "step" word and haven't found any other mentions.

@subatoi subatoi added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team needs SME This proposal needs review from a subject matter expert and removed triage Do not begin working on this issue until triaged by the team labels Jan 29, 2025
@github-actions GitHub Actions
Copy link
Contributor

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

@subatoi
Copy link
Contributor

subatoi commented Jan 29, 2025

Hi @mil-dot, thanks for raising a PR—I'll get this triaged for review by a member of the team.

subatoi
subatoi reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@subatoi subatoi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mil-dot, I asked our Actions team to take a look and this, and I've made some suggestions based on readability and their feedback. The bottom line is that they agreed with your reasoning and we do want to make these changes. Unless you have any specific concerns, I'd like to apply the suggestions and merge this. Thank you!

...-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs.md Outdated Show resolved Hide resolved
...-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs.md Outdated Show resolved Hide resolved
@subatoi subatoi removed the needs SME This proposal needs review from a subject matter expert label Jan 29, 2025
mil-dot and others added 3 commits January 29, 2025 17:21
@mil-dot @subatoi
Update content/actions/writing-workflows/choosing-what-your-workflow-…
b461fb9 
…does/control-the-concurrency-of-workflows-and-jobs.md


Better wording

Co-authored-by: Ben Ahmady <[email protected]>
@mil-dot @subatoi
Update content/actions/writing-workflows/choosing-what-your-workflow-…
23950d9 
…does/control-the-concurrency-of-workflows-and-jobs.md


Better wording

Co-authored-by: Ben Ahmady <[email protected]>
@mil-dot
Merge branch 'main' into patch-1
b9f3d72
subatoi
subatoi approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@subatoi subatoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again! I'll get this merged now. Thanks for your interest in the GitHub docs, and your help

@mil-dot
Copy link
Contributor Author

mil-dot commented Jan 29, 2025

Hey @subatoi, thank you for getting this done so fast. Looks good to me, feel free to proceed at your convenience or let me know if anything else is needed from my side.

@subatoi subatoi added this pull request to the merge queue Jan 29, 2025
Merged via the queue into github:main with commit 25d6109 Jan 29, 2025
45 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@mil-dot mil-dot deleted the patch-1 branch January 29, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BREYES2024 BREYES2024 BREYES2024 left review comments

@subatoi subatoi subatoi approved these changes

Assignees
No one assigned
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mil-dot @subatoi @BREYES2024