Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to axum 0.8 #151

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Bump to axum 0.8 #151

merged 1 commit into from
Jan 8, 2025

Conversation

CleanCut
Copy link
Contributor

@CleanCut CleanCut commented Jan 6, 2025

I updated axum to 0.8 in crates/twirp/Cargo.toml and then ran cargo test (which passed!) and committed the resulting updated Cargo.lock file.

@jorendorff How can I make sure this doesn't break things that use it? Will opening up a PR on blackbird that points to this branch for twirp-rs* be sufficient?

Resolves #150

Once this is tested and merged, I anticipate publishing a new version of twirp-rs and twirp-build-rs to crates.io.

@Copilot Copilot bot review requested due to automatic review settings January 6, 2025 21:06
@CleanCut CleanCut requested a review from a team as a code owner January 6, 2025 21:06

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@jorendorff
Copy link
Contributor

How can I make sure this doesn't break things that use it? Will opening up a PR on blackbird that points to this branch for twirp-rs* be sufficient?

Good idea. We don't have a better way. Looking at the axum 0.8 release notes, it appears this is a pretty big change, so I suggest doing a breaking version-bump here as well (to twirp-rs 0.8 or whatever).

The changes might not affect Blackbird - for example, I don't think we get any parameters from parsing request paths - but all three of the breaking changes described in the release notes affect things I've at least heard of, and it says there are other "less visible" breaking changes as well, so I'm not super optimistic.

@CleanCut
Copy link
Contributor Author

CleanCut commented Jan 7, 2025

I made a blackbird PR that pulls in the twirp-rs bump of axum 0.8. CI passes! 🥳 🎉

@jorendorff Do we need to do some live tests in non-serving production clusters as well, before feeling good about finalizing the various PRs involved?

@jorendorff
Copy link
Contributor

@CleanCut Please branch-deploy to a non-serving cluster. The probers will tell us if anything's seriously wrong.

@CleanCut
Copy link
Contributor Author

CleanCut commented Jan 8, 2025

Branch deployed, ran all night, no problems! 👍🏻

Copy link
Contributor

@jorendorff jorendorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@CleanCut CleanCut added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit e087e60 Jan 8, 2025
2 checks passed
@CleanCut CleanCut deleted the axum-0.8 branch January 8, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump to Axum 0.8
2 participants