Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust 1.76, refactor use of features #20

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Rust 1.76, refactor use of features #20

merged 4 commits into from
Mar 20, 2024

Conversation

tclem
Copy link
Member

@tclem tclem commented Mar 20, 2024

There was an attempt to have a client and server feature, but the generated code doesn't support this so it's confusing and half implemented. Let's remove it entirely for now.

  • Upgrades Rust
  • Adds linting to the CI job
  • Uses our re-exports of common dependencies which makes it easier to pull in the library and the deps it was built with.

@tclem tclem requested a review from a team as a code owner March 20, 2024 20:09
@tclem tclem changed the title Rust 1.76, refactor us of features Rust 1.76, refactor use of features Mar 20, 2024
@tclem tclem merged commit acd63b9 into main Mar 20, 2024
2 checks passed
@tclem tclem deleted the tclem/refactor-features branch March 20, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorendorff jorendorff jorendorff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tclem @jorendorff