Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kev/499_transform_rescale_test #863

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

Conversation

junhaow1
Copy link
Collaborator

@junhaow1 junhaow1 commented Jan 29, 2025

Pull Request Details

What issue does this PR address

Checklist

Complete the check-list below to ensure your branch is ready for PR.

Flutter Style Guide: https://survivor.togaware.com/gnulinux/flutter-style.html

  • Screenshots included in linked issue
  • Changes adhere to the style and coding guideline NON CONFORMACE Please only tick if conforms
  • No confidential information
  • No duplicated content
  • No lint check errors related to your changes (make prep or flutter analyze lib)
  • Pre-exisiting lint errors noted: [HERE]
  • Integration test make qtest.tmp screenshot included in issue
  • Tested on device:
    • Linux
    • MacOS
    • Windows
  • Added two reviewers

Finalising

Once PR discussion is complete and reviewers have approved:

  • Merge dev into the branch
  • Resolve any conflicts
  • Add one line summary into CHANGELOG.md
  • Bump appropriate version number in pubspec.yaml
  • Push to git repository and review
  • Merge PR into dev (gjwgit)


/// Verify the Rescale feature on the DEMO dataset.
/// tap chip, press button, verify car name , verify stats.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change of naming style?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Owner

@gjwgit gjwgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure this PR is ready to submit as a PR.

@gjwgit gjwgit requested review from zheyxu and removed request for zheyxu January 29, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants