fatcat: stake #379
Open
fatcat: stake #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x0ece
force-pushed
the
fatcat-stake
branch
2 times, most recently
from
827e1d9 to
7694623
Compare
0x0ece
commented
Jan 28, 2025
0x0ece
commented
Jan 28, 2025
| return false; | ||
| return ( | ||
| //@ts-ignore | ||
| window?.phantom?.solana?.isPhantom && window?.phantom?.solana?.isConnected |
There was a problem hiding this comment.
This now means that Phantom adds ComputeBudget by itself (see where isPhantom is used). Let's try it for a bit, if we don't like it we can revert.
0x0ece
commented
Jan 28, 2025
| preInstructions.push( | ||
| // @ts-ignore | ||
| await this.base.program.methods | ||
| .toggleMaxLock(true) |
There was a problem hiding this comment.
I staked JUP and saw that this is added in the initial tx.
When I tried fatcat without this I was getting an error, so I assume default is false, i.e. this ix is needed on creation.
yurushao
reviewed
Jan 28, 2025
| @@ -341,7 +341,7 @@ pub fn init_locked_voter_escrow_handler<'info>(ctx: Context<InitLockedVoterEscro | |||
| locker: ctx.accounts.locker.to_account_info(), | |||
| escrow: ctx.accounts.escrow.to_account_info(), | |||
| escrow_owner: ctx.accounts.vault.to_account_info(), | |||
| payer: ctx.accounts.vault.to_account_info(), | |||
| payer: ctx.accounts.signer.to_account_info(), | |||
| system_program: ctx.accounts.system_program.to_account_info(), | |||
| }, | |||
| vault_signer_seeds, | |||
There was a problem hiding this comment.
if paid by signer we probably don't need vault_signer_seeds.
There was a problem hiding this comment.
oh right, I'll review them all
There was a problem hiding this comment.
ok, I removed the seeds from new_escrow and new_vote. The others move assets so most likely require the seeds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.