refactoring hsm

glific · Jan 2, 2025 · 0a27dd2 · 0a27dd2
1 parent 910ea99
commit 0a27dd2
Show file tree

Hide file tree

Showing 3 changed files with 401 additions and 376 deletions.
diff --git a/src/containers/Form/FormLayout.tsx b/src/containers/Form/FormLayout.tsx
@@ -179,7 +179,7 @@ export const FormLayout = ({
       }
     });
     // for template create media for attachment
-    if (isAttachment && payload.type !== 'TEXT' && payload.type) {
+    if (isAttachment && payload.type !== 'TEXT' && payload.type && !entityId) {
       getMediaId(payload)
         .then((data: any) => {
           if (data) {
@@ -576,6 +576,8 @@ export const FormLayout = ({
               color="primary"
               onClick={() => {
                 formik.validateForm().then((errors) => {
+                  console.log(errors);
+
                   onSaveButtonClick(errors);
                   formik.submitForm();
                 });

diff --git a/src/containers/HSM/HSM.test.tsx b/src/containers/HSM/HSM.test.tsx
@@ -3,11 +3,7 @@ import { MockedProvider } from '@apollo/client/testing';
 import userEvent from '@testing-library/user-event';
 import { MemoryRouter, Route, Routes } from 'react-router-dom';
 import { HSM } from './HSM';
-import {
-  HSM_TEMPLATE_MOCKS,
-  getHSMTemplateTypeMedia,
-  getHSMTemplateTypeText,
-} from 'mocks/Template';
+import { HSM_TEMPLATE_MOCKS, getHSMTemplateTypeMedia, getHSMTemplateTypeText } from 'mocks/Template';
 import { setNotification } from 'common/notification';
 
 const mocks = HSM_TEMPLATE_MOCKS;
@@ -155,14 +151,13 @@ describe('Add mode', () => {
     await waitFor(() => {
       expect(screen.getByText('Hi, How are you {{1}}')).toBeInTheDocument();
     });
-    fireEvent.change(inputs[1], { target: { value: 'element_name' } });
 
     fireEvent.change(screen.getByPlaceholderText('Define value'), { target: { value: 'User' } });
-    fireEvent.change(inputs[1], { target: { value: 'title' } });
 
     autocompletes[3].focus();
     fireEvent.keyDown(autocompletes[3], { key: 'ArrowDown' });
     fireEvent.click(screen.getByText('Messages'), { key: 'Enter' });
+    fireEvent.change(inputs[1], { target: { value: 'title' } });
 
     fireEvent.click(screen.getByTestId('submitActionButton'));