Use NB_STATIC on windows.

glotzerlab · Jun 24, 2024 · c17401a · c17401a
1 parent a5e0e9a
commit c17401a
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -59,6 +59,13 @@ if(nanobind_FOUND)
     "[${nanobind_DIR},${nanobind_VERSION}]")
 endif()
 
+# shared nanobind linking seems broken on windows for unknown reasons
+if(WIN32)
+  set(freud_nanobind_linking "NB_STATIC")
+else()
+  set(freud_nanobind_linking "NB_SHARED")
+endif()
+
 # Fail fast if users have not cloned submodules.
 if(NOT WIN32)
   string(ASCII 27 Esc)

diff --git a/cpp/box/CMakeLists.txt b/cpp/box/CMakeLists.txt
@@ -1,5 +1,5 @@
 # create the target and add the needed properties
-nanobind_add_module(_box NB_SHARED module-box.cc export_Box.cc)
+nanobind_add_module(_box ${freud_nanobind_linking} module-box.cc export_Box.cc)
 target_link_libraries(_box PUBLIC libfreud)
 
 if(APPLE)

diff --git a/cpp/parallel/CMakeLists.txt b/cpp/parallel/CMakeLists.txt
@@ -1,4 +1,4 @@
-nanobind_add_module(_parallel NB_SHARED module-parallel.cc)
+nanobind_add_module(_parallel ${freud_nanobind_linking} module-parallel.cc)
 target_link_libraries(_parallel PUBLIC libfreud)
 
 if(APPLE)