Convert parallel module to nanobind #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommy-waltmann
requested review from
SchoeniPhlippsn
and removed request for
a team
for more information, see https://pre-commit.ci
joaander
approved these changes
Jun 24, 2024
Comment on lines
+4
to
+12
| if(APPLE) | ||
| set_target_properties(_parallel PROPERTIES INSTALL_RPATH "@loader_path") | ||
| else() | ||
| set_target_properties(_parallel PROPERTIES INSTALL_RPATH "\$ORIGIN") | ||
| endif() | ||
|
|
||
| if(_using_conda OR DEFINED ENV{CIBUILDWHEEL}) | ||
| set_target_properties(_parallel PROPERTIES INSTALL_RPATH_USE_LINK_PATH True) | ||
| endif() |
There was a problem hiding this comment.
Will need to move this to a CMake macro or function to avoid code duplication as we add more modules.
There was a problem hiding this comment.
Yes, I can do this on the next PR for the parallel module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR converts the parallel module to use nanobind and separates libfreud from the python extension modules.
Motivation and Context
This is the next module in our conversion of freud to use nanobind.
How Has This Been Tested?
The existing tests in
test_parallel.pypass.Types of changes
Checklist: