Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the build system #1275

Merged
merged 12 commits into from
Sep 6, 2024
Merged

Refactor the build system #1275

merged 12 commits into from
Sep 6, 2024

Conversation

joaander
Copy link
Member

@joaander joaander commented Aug 30, 2024

Description

  • Use scikit-build-core.
  • Assemble a functioning freud package in the build directory.

Motivation and Context

scikit-build-core is more pleasant to work with than scikit-build. However, it still does not provide status messages during successful builds. Therefore, I enabled pure CMake builds to assemble a working package in the build directory. This allows developers to iteratively modify, build, and test freud while observing the build status and not polluting their Python environment.

How Has This Been Tested?

Tested locally on my Mac and Linux workstations.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds or improves functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation improvement (updates to user guides, docstrings, or developer docs)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have updated the documentation (if relevant).
  • I have added tests that cover my changes (if relevant).
  • All new and existing tests passed.
  • I have updated the credits.
  • I have updated the Changelog.

@joaander joaander force-pushed the refactor-build branch 2 times, most recently from cd3b2ce to 3f9b2dd Compare August 30, 2024 12:59
@joaander joaander marked this pull request as ready for review August 30, 2024 15:40
@joaander joaander force-pushed the refactor-build branch 2 times, most recently from 225332b to 85e3431 Compare September 4, 2024 13:13
@joaander joaander mentioned this pull request Sep 5, 2024
7 tasks
@joaander joaander requested a review from DomFijan September 5, 2024 13:13
Base automatically changed from nanobind-pmft to nanobind September 6, 2024 13:08
@joaander joaander merged commit c61aca6 into nanobind Sep 6, 2024
48 of 50 checks passed
@joaander joaander deleted the refactor-build branch September 6, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant