fix: logging file creation from jars and package #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…outside of a JAR. This bug was introduced in 2021; gluonhq#371. The approach (setting a file properly) did not work, as the JDK's LogManager failed to find the file -- inside a jar -- and silently fails (frustratingly), resulting in no logging config at all. That is not how that property is intended to be used (an external file is assumed as FileInputStream is used). Another approach is to use java.util.logging.config.class and specify a class (with a job of setting properties).
This was referenced Oct 18, 2023
abhinayagarwal
changed the title
|
I have tested the fix against source, jar and dmg package. It runs under all conditions. |
abhinayagarwal
previously approved these changes
Oct 24, 2023
app/src/main/java/com/oracle/javafx/scenebuilder/app/SceneBuilderApp.java
Outdated
Show resolved
Hide resolved
Thank you! |
…mment improvement.
credmond
changed the title
credmond
changed the title
|
Sorry @abhinayagarwal , I renamed the title after you renamed it (I didn't realise you had changed it -- I thought it was my original), I put it back to your version... :) |
abhinayagarwal
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed logging file, which previously only worked from an IDE / local run outside of a JAR. This bug was introduced in 2021; #371. The approach (setting a file property) did not work, as the JDK's LogManager failed to find the file -- inside a jar -- and silently fails (frustratingly), resulting in no logging config at all. That is not how that property is intended to be used (an external file is assumed as FileInputStream is used). Another approach that would work is to use java.util.logging.config.class and specify a class (with the job of setting properties). This fix is a shortcut to basically do the same thing.
Issue
No logging file was created nor logged to.
Fixes #661
As per commit message.
Progress