Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove/Update Kit third-party dependencies #758

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

jperedadnr
Copy link
Collaborator

Issue

Fixes #757

Before this PR, when running the application, Maven warns about:

[WARNING] *****************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************
[WARNING] * Required filename-based automodules detected: [aether-api-1.1.0.jar, aether-impl-1.1.0.jar, aether-spi-1.1.0.jar, aether-util-1.1.0.jar, aether-connector-basic-1.1.0.jar, aether-transport-file-1.1.0.jar, aether-transport-http-1.1.0.jar, maven-aether-provider-3.3.9.jar, plexus-utils-3.0.22.jar, commons-lang3-3.4.jar, javax.json-api-1.0.jar]. Please don't publish this project to a public artifact repository! *
[WARNING] *****************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************

After this PR, the warning is fully gone.

The very old dependencies aether-api-1.1.0.jar, aether-impl-1.1.0.jar, aether-spi-1.1.0.jar, aether-util-1.1.0.jar, aether-connector-basic-1.1.0.jar, aether-transport-file-1.1.0.jar, aether-transport-http-1.1.0.jar, maven-aether-provider-3.3.9.jar, plexus-utils-3.0.22.jar, commons-lang3-3.4.jar are replaced with a very recent org.apache.maven.resolver:2.0.0-alpha-8 (and many transitive dependencies), javax.json-api-1.0.jar is replaced with jakarta.json, and the apache httpComponents are replaced with the built-in HttpClient from the JDK.

There are a number of changes, so I've split them in 4 different consecutive commits, for a better understanding.

Progress

@jperedadnr jperedadnr changed the title Remove/Update Kit third-party dependencies feat: Remove/Update Kit third-party dependencies Oct 21, 2024
@jperedadnr jperedadnr merged commit 91f6846 into gluonhq:master Oct 22, 2024
3 checks passed
@jperedadnr jperedadnr deleted the 757-olddependencies branch October 22, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove/update old dependencies from Scene Builder Kit
3 participants