Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSUB-1144: Update smart contract test tool to 0.1.5 #402

Merged
merged 2 commits into from
Jun 18, 2024
Merged

CSUB-1144: Update smart contract test tool to 0.1.5 #402

merged 2 commits into from
Jun 18, 2024

Conversation

atodorov
Copy link
Contributor

Description of proposed changes

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@github-actions GitHub Actions
Copy link

For full LLVM coverage report click here!

@atodorov atodorov force-pushed the testing/CSUB-1144-update-smartcontract-tool branch from fb8d868 to 94f6d42 Compare June 18, 2024 14:02
@atodorov atodorov marked this pull request as ready for review June 18, 2024 14:03
@atodorov atodorov requested a review from a team as a code owner June 18, 2024 14:03
@atodorov atodorov requested review from Retamogordo and mostafaesmaeilli and removed request for a team June 18, 2024 14:03
@atodorov
Copy link
Contributor Author

Moved enablement of new test tool into #403 b/c there are some unexpected failures.

@atodorov atodorov requested review from DylanVerstraete and beqaabu and removed request for Retamogordo and mostafaesmaeilli June 18, 2024 14:04
@atodorov atodorov changed the title CSUB-1144: Update smart contract test tool to 0.1.5 & enable stateOverrideTest CSUB-1144: Update smart contract test tool to 0.1.5 Jun 18, 2024
@atodorov atodorov merged commit 6bfc691 into dev Jun 18, 2024
52 checks passed
@atodorov atodorov deleted the testing/CSUB-1144-update-smartcontract-tool branch June 18, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beqaabu beqaabu beqaabu approved these changes

@DylanVerstraete DylanVerstraete DylanVerstraete approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atodorov @DylanVerstraete @beqaabu