Code review

README.md

@@ -2,22 +2,6 @@
 
 A Creditcoin3 node with the Ethereum RPC support, ready for deploying smart contracts.
 
-## Generation & Upstream
-
-This project was originally forked from the Frontier template. The template is maintained in the
-[Frontier](https://github.com/paritytech/frontier/tree/master/template) project repository, and can
-be used to generate a stand-alone template for use in an independent project via the included
-[template generation script](https://github.com/paritytech/frontier/blob/master/docs/node-template-release.md).
-
-A ready-to-use template generated this way is hosted for each Frontier release on the
-[substrate-developer-hub/frontier-node-template](https://github.com/substrate-developer-hub/frontier-node-template)
-repository.
-
-This template was originally forked from the
-[Substrate Node Template](https://github.com/substrate-developer-hub/substrate-node-template). You
-can find more information on features on this template there, and more detailed usage on the
-[Substrate Developer Hub Tutorials](https://docs.substrate.io/tutorials/v3/) that use this heavily.
-
 ## Build & Run
 
 To build the chain, execute the following commands from the project root:

runtime/src/lib.rs

@@ -242,16 +242,15 @@ impl frame_system::Config for Runtime {
 }
 
 parameter_types! {
-    pub const MaxAuthorities: u32 = 100;
-
     pub const ReportLongevity: u64 =
         BondingDuration::get() as u64 * SessionsPerEra::get() as u64 * EpochDuration::get();
+    pub const MaxAuthorities: u32 = 100;
 }
 
 impl pallet_grandpa::Config for Runtime {
     type RuntimeEvent = RuntimeEvent;
     type WeightInfo = ();
-    type MaxAuthorities = ConstU32<32>;
+    type MaxAuthorities = MaxAuthorities;
     type MaxNominators = ConstU32<0>;
     type MaxSetIdSessionEntries = ();
     type KeyOwnerProof = <Historical as KeyOwnerProofSystem<(KeyTypeId, GrandpaId)>>::Proof;
@@ -657,7 +656,6 @@ parameter_types! {
     pub const MaxPending: u32 = 64;
     pub const AnnouncementDepositBase: u128 = 500;
     pub const AnnouncementDepositFactor: u128 = 500;
-
 }
 
 impl pallet_proxy::Config for Runtime {

runtime/src/version.rs

@@ -8,7 +8,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
     impl_name: create_runtime_str!("creditcoin3"),
     authoring_version: 3,
     spec_version: 9,
-    impl_version: 2,
+    impl_version: 3,
     apis: RUNTIME_API_VERSIONS,
     transaction_version: 2,
     state_version: 1,

testing/README.md

@@ -6,7 +6,6 @@ Currently this directory contains a smart contract test suite, written by the
 SmartContract team at Gluwa. Its purpose is to verify Creditcoin 3 support for
 various smart contract functionalities.
 
-
 ## How to execute
 
 1. Install the dependencies
@@ -15,7 +14,7 @@ various smart contract functionalities.
 npm install
 ```
 
-1. Execute the test suite
+2. Execute the test suite
 
 ```bash
 ./node_modules/.bin/basicTest --rpc <creditcoin-rpc-url> --private_key <private-key-for-a-funded-account>