-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ivy Saskia Sejas Rocabado - react-eth-challenge #114
Open
IvySaskia
wants to merge
17
commits into
gndx:main
Choose a base branch
from
IvySaskia:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
Solución al reto: http://react-eth-challenge-navy.vercel.app
Nombre: Ivy Saskia Sejas Rocabado
Usuario Platzi: Ivy Saskia
Reto:
[#6] Documentación
Create the project components #1
Se cambio el uso de mount a shallow en los tests.
Se cambió la dependencia babel-eslint por @babel/eslint-parser.
Se actualizó el archivo index para que pueda ser compatible con React 18
Se crearon los componentes About, Academic, Experience, Header, Interest, Languages, Profile, Skills según TDD.
Add styles #2
Se uso una plantilla mediante tailwind css. Tambien, se tomo en cuenta una vista de error si pasa algo, y una vista de cargando cuando se obtenga los datos.
Create getData.js function #3
Se construye la función getData con fetch
Integrate API #4
Para realizar la integración del API y se levanta el servidor mediente el comando npm run server.
Custom API #5
Se actualiza la data.json con los datos personales y se utiliza un cloud api como proveedor de data.
Document #6
Como parte de la documentación esta cada commit con los mensajes de lo que se realizo, enfocandose en cada issue que existe.
Deploy #7
Se realizó el despliegue en vercel http://react-eth-challenge-navy.vercel.app