Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pretty printing XML #565

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Add support for pretty printing XML #565

merged 3 commits into from
Jan 24, 2024

Conversation

satabin
Copy link
Member

@satabin satabin commented Jan 22, 2024

  • Pretty rendering Pipe
  • Pretty Collector
  • Documentation

Closes #560

@satabin satabin force-pushed the xml/pretty-printing branch 4 times, most recently from 42f092e to c89380d Compare January 23, 2024 18:30
@satabin satabin force-pushed the xml/pretty-printing branch from c89380d to 5984134 Compare January 23, 2024 18:43
@satabin satabin added this to the 1.11.0 milestone Jan 23, 2024
@satabin satabin marked this pull request as ready for review January 23, 2024 19:43
@satabin satabin requested a review from a team as a code owner January 23, 2024 19:43
@satabin
Copy link
Member Author

satabin commented Jan 23, 2024

@Baccata Does it cover what you had in mind?

@Baccata
Copy link

Baccata commented Jan 23, 2024

It very much does ! Thank you 😃

@satabin
Copy link
Member Author

satabin commented Jan 24, 2024

It motivated me to read again literature on PP in a streaming context, and I will seriously investigate implementing something like this in fs2-data

Copy link
Collaborator

@ybasket ybasket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satabin satabin merged commit b2a70b5 into main Jan 24, 2024
28 checks passed
@satabin satabin deleted the xml/pretty-printing branch January 24, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for a "formatted rendering" XML sink
3 participants