-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add small Nix shell for development #615
Conversation
Looks like a cool addition! Could you add a small usage note to the Readme though for discoverability and for people with little Nix experience like me? |
Maybe we could go further and take the Typelevel nix flake. WDYT? |
f488cbc
to
050d55a
Compare
@satabin I took the typelevel-nix snippet and just removed the sbt microsites section and switched the JDK to from 8 to 11. WDYT? Should there be other modifications of the typelevel base? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested on macOS with fresh Nix install and it worked fine 👍
PS: Please avoid force pushes once a PR is open, makes review harder.
Sorry @ybasket , duly noted 😬 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the contribution.
No description provided.