Replace few recursions #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancywriter
force-pushed
the
feature/recursion-fold
branch
from
2fdf020 to
4cb5320
Compare
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
==========================================
- Coverage 38.63% 38.49% -0.14%
==========================================
Files 43 43
Lines 1522 1517 -5
Branches 167 157 -10
==========================================
- Hits 588 584 -4
+ Misses 934 933 -1
Continue to review full report at Codecov.
|
fancywriter
force-pushed
the
feature/recursion-fold
branch
from
4cb5320 to
c3d9892
Compare
fancywriter
force-pushed
the
feature/recursion-fold
branch
from
c3d9892 to
fd23c61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although it didn't help me (yet) to find the solution to stack overflow error, it is still better, less lines and easier to understand. I still don't understand what
pushmethod does though... and I didn't do much optimization with it... looks like it can be three nestedfoldLeft, but not sure yet if possible.