Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues in adding goerli support #845

Open
wants to merge 4 commits into
base: goerli-support
Choose a base branch
from
Open

Fix issues in adding goerli support #845

wants to merge 4 commits into from

Conversation

AireshBhat
Copy link

  • Fixed issue in Goerli name. Changed from "GOERLI" to "GÖRLI" wherever necessary.
  • Update chain id from 4 to 5 in the connectors file.

segun
segun reviewed Dec 12, 2022
View reviewed changes
src/connectors/index.ts
@@ -50,8 +50,8 @@ export const walletconnect = {
qrcode: true,
pollingInterval: POLLING_INTERVAL,
}),
4: new WalletConnectConnector({
rpc: { 4: NETWORK_CONFIGS[4].rpc },
5: new WalletConnectConnector({
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will remove support for rinkeby...I think add a new option for Goerli and leave chain id 4 as it is.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, the previous commit in this branch mentioned that Rinkeby support was to be removed in replace of Goerli. There was no reference to Rinkeby in the code apart from this file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@segun segun segun left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AireshBhat @segun