update sequence diagram in readme

gnosisguild · Aug 9, 2024 · 22ad698 · 22ad698
1 parent 2926764
commit 22ad698
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -32,7 +32,7 @@ sequenceDiagram
             activate Ciphernode Registry
                 Ciphernode Registry -->> Ciphernodes: Key Setup
                 activate Ciphernodes
-                    Ciphernodes -->> Ciphernode Registry: Publish shared key
+                    Ciphernodes -->> Ciphernode Registry: Publish shared keys
                 deactivate Ciphernodes
                 Ciphernode Registry -->> Enclave: Publish Committee
             deactivate Ciphernode Registry

diff --git a/packages/evm/contracts/Enclave.sol b/packages/evm/contracts/Enclave.sol
@@ -111,9 +111,6 @@ contract Enclave is IEnclave, OwnableUpgradeable {
     function request(
         address filter,
         uint32[2] calldata threshold,
-        // TODO: do we also need a start block/time? Would it be possible to have computations where inputs are
-        // published before the request is made? This kind of assumes the cypher nodes have already been selected
-        // and generated a shared secret.
         uint256[2] calldata startWindow,
         uint256 duration,
         IComputationModule computationModule,
@@ -147,7 +144,7 @@ contract Enclave is IEnclave, OwnableUpgradeable {
             ModuleNotEnabled(address(executionModule))
         );
 
-        // TODO: should IDs be incremental or produced deterministic?
+        // TODO: should IDs be incremental or produced deterministically?
         e3Id = nexte3Id;
         nexte3Id++;