-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate ENS Record Setting in UI #256
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, just one note:
We will probably need some way of getting the user to change chain to mainnet, if they are not already on mainnet, since the ENS record is always set on mainnet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work Julio!
Thanks, for your feedback @manboy-eth, I already applied the following changes:
Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, much better :)
But did you do anything to handle this?
We will probably need some way of getting the user to change chain to mainnet, if they are not already on mainnet, since the ENS record is always set on mainnet.
When the user for instance has a publication on Gnosis Chain, the user must still set the ENS record on mainnet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, now we just need some minor changes and I think this is ready to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, now we just need some minor changes and I think this is ready to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, now we just need some minor changes and I think this is ready to merge.
Description:
closes #253
Problem:
Currently, there's no direct way in the UI for users to set their ENS record. Users have to manually add their publication hash to their ENS record, as shown in the example: ENS Domain Example. While they can access it at
tabula.gg/#/yourCustomEns
, and the app will automatically detect the ENS, the process could be more streamlined.Solution:
This PR integrates the
multicall
andsetText
methods from the ENS contract directly into our UI. Users can now easily set their ENS record by adding a button within the publications section. This button will execute all the necessary logic and explain to the user about the underlying processes.Changes:
EnsProvider
from./services/ens/context
.useEnsContext
and refactoring the logic.Additional Context:
The goal of this PR is to enhance the user experience by simplifying the setting of ENS records and clarifying what happens in the background.
Reviewer Checklist:
Screenshots
![image](https://github.com/gnosis/tabula/assets/19823989/4a5136b5-dd9f-4275-bb60-a7b4d86f919d)