Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix commit status events #33320

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix commit status events #33320

wants to merge 2 commits into from

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 18, 2025 •
edited
Loading

Fix #33302
Fix #33244

depends on #33396

A part of this PR should be backported to v1.23 manually.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 18, 2025
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 18, 2025
@lunny lunny added type/bug backport/v1.23 This PR should be backported to Gitea 1.23 and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 18, 2025
@github-actions github-actions bot added modifies/translation modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Jan 18, 2025
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 18, 2025
This was referenced Jan 20, 2025
Merged
Open
lunny added a commit that referenced this pull request Jan 23, 2025
@lunny
Refactor webhook events (#33337)
e94f37f 
Extract from #33320

This PR uses a map instead of a struct to store webhook event
information. It removes many duplicated functions and makes the logic
clearer.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 23, 2025
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 23, 2025
@lunny lunny marked this pull request as ready for review January 23, 2025 20:38
@lunny
Copy link
Member Author

lunny commented Jan 23, 2025

This is ready to review now.

@lunny lunny mentioned this pull request Jan 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
No milestone
2 participants
@lunny @GiteaBot