Add go wrapper around git diff-tree --raw -r -M #33369
Open
+566
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
McRaeAlex
commented
Jan 23, 2025
McRaeAlex
commented
- Implemented calling git diff-tree
- Ensures wrapper function is called with valid arguments
- Parses output into go struct, using strong typing when possible
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XL
McRaeAlex
force-pushed
the
gitea/am/diff-tree
branch
from
a1fb10e to
bdfd379
Compare
|
Context for this PR: This was split out of a larger PR I hope to upstream to gitea for showing all files in a file tree at once rather than having a show more button at the bottom.
Note that this wouldn't change the behaviour of the files list to the right of the file tree. (Lets have that discussion in the PR which modifies the frontend) |
lunny
reviewed
Jan 24, 2025
* Implemented calling git diff-tree * Ensures wrapper function is called with valid arguments * Parses output into go struct, using strong typing when possible
McRaeAlex
force-pushed
the
gitea/am/diff-tree
branch
from
bdfd379 to
da24f58
Compare
lunny
reviewed
Jan 26, 2025
| return nil, err | ||
| } | ||
|
|
||
| cmd := git.NewCommand(ctx, "diff-tree", "--raw", "-r", "--find-renames").AddDynamicArguments(baseCommitID, headCommitID) |
There was a problem hiding this comment.
For pull request files changed page, it needs baseCommitID...headCommitID. I think it's better to have another parameter to let outside functions decide it.
lunny
reviewed
Jan 26, 2025
| return baseCommit.ID.String(), headCommit.ID.String(), nil | ||
| } | ||
|
|
||
| func parseGitDiffTree(output string) ([]*DiffTreeRecord, error) { |
There was a problem hiding this comment.
How about to use rd io.Reader as the parameter?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.