feat: Client Circuit Breaker

[segevda]

Adds a circuit breaker to resty.Client which disables requests for a specified period of time upon multiple failures.
Default behavior is counting 5xx errors, but users can implement their own policies.

Resolves #448

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.81%. Comparing base (f2a67d3) to head (69e85d9).
Report is 1 commits behind head on v3.

Additional details and impacted files

@@           Coverage Diff           @@
##               v3     #930   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          16       17    +1     
  Lines        3695     3781   +86     
=======================================
+ Hits         3688     3774   +86     
  Misses          5        5           
  Partials        2        2           

Flag	Coverage Δ
unittests	99.81% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jeevatkm]

@segevda - Thanks for the PR. Please incorporate the comments and suggestions.

@ccoVeille - Thanks for your review and input.

[segevda]

@ccoVeille @jeevatkm thanks for the review!

[jeevatkm]

@segevda Could you please remove the go.mod and go.sum changes from this PR?

[segevda]

@segevda Could you please remove the go.mod and go.sum changes from this PR?

oops. removed

[ccoVeille]

I feel like I contributed to this PR 😅

Adding a Co-authored-by tag to your commit would be appreciated then 😬

Co-authored-by: ccoVeille <[email protected]>

https://docs.github.com/articles/creating-a-commit-with-multiple-authors

[jeevatkm]

I feel like I contributed to this PR 😅

Adding a Co-authored-by tag to your commit would be appreciated then 😬

Co-authored-by: ccoVeille <[email protected]>

https://docs.github.com/articles/creating-a-commit-with-multiple-authors

@ccoVeille Certainly, you have contributed via Reviewing PR. This is the first time I received this kind of request. I believe adding a reviewer tag is appropriate as follows -

Reviewed-by: ccoVeille <[email protected]>

What do you think?

[ccoVeille]

I feel like I contributed to this PR 😅

Adding a Co-authored-by tag to your commit would be appreciated then 😬

Co-authored-by: ccoVeille <[email protected]>

https://docs.github.com/articles/creating-a-commit-with-multiple-authors

@ccoVeille Certainly, you have contributed via Reviewing PR.
This is the first time I received this kind of request.

GitHub supports co-authored-by natively when the owner or author uses commit feature on the suggestion provided by a contributor. So you may already have commits with such tags.

I believe adding a reviewer tag is appropriate as follows -

Reviewed-by: ccoVeille <[email protected]>

What do you think?

Yes, sure. Reviewed-By is less used but why not.

This tag is automatically added to merge commit on GitLab if the project is configured to support it via the templating system.

I don't know if it can be configured on GitHub

[ccoVeille]

So you may already have commits with such tags.

Confirmed, I found one pretty easily: 9097b96

[ccoVeille]

This is the first time I received this kind of request.

About why I asked, there are multiple reasons:

• I did contribute to the PR
• I like to spread the knowledge, and here I could share the idea
• code reviewing is important and owner/author apply code changes within their IDE, attributing themselves the idea
• visibility of my contributions to OSS project
• vanity (haha)

[segevda]

@jeevatkm @ccoVeille squashed the commits with a more conventional commit msg and added the Reviewed-by trailer as agreed

[ccoVeille]

Thanks. My request was to have a co-authored-by tag.

@jeevatkm agreed and asked to add also the reviewed-by tag.

You squashed and used the reviewed-by tag.

But now, I'm not getting the tag I asked for 😅

Can I also get the co-authored-by one? Haha

[jeevatkm]

@segevda, I just reviewed the code suggestion conversation history on this PR. @ccoVeille suggested code snippets, which GitHub typically considers as co-authors.

Can you please remove the reviewed-by tag and add the co-authored-by tag? Many thanks for considering my request.

Co-authored-by: ccoVeille <[email protected]>

---

@ccoVeille, if you're interested in contributing further to the documentation examples of the upcoming Resty v3 release, let me know, and I will share the line items.

[segevda]

Can you please remove the reviewed-by tag and add the co-authored-by tag? Many thanks for considering my request.

Done 🙂

[ccoVeille]

I could help maybe yes. I can easily review and provide feedbacks about PR. I can do it from my couch, as I do now. Coding changes requires more efforts 😅

[jeevatkm]

Thanks, @segevda, for incorporating the review comments and the request.

[jeevatkm]

I could help maybe yes. I can easily review and provide feedbacks about PR. I can do it from my couch, as I do now. Coding chances requires more efforts 😅

@ccoVeille I meant creating a new example in documentation, not PR feedback. Of course, you could chime in when you see a PR.