Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: HTTPNode.Location when building graph #2007

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

jeongukjae
Copy link
Contributor

@jeongukjae jeongukjae commented Jan 20, 2025

After this commit, building internal graph can raise error because HTTPNode's Location value can be changed while building graph. (See line 65 (node.URL = url))

So if taskfile imports remote file with multiple depth (e.g. A --> remote B --> remote C) without filename, it raises

source vertex https://{PATH_TO_REMOTE}/Taskfile.yaml: vertex not found

So fixing HTTPNode.Location not to be changed over time.

(I couldn't find any related issues, so please let me know if there's issue or I have to create it)

@pd93 pd93 requested review from pd93 and vmaerten January 21, 2025 11:46
@vmaerten vmaerten changed the title Fix HTTPNode.Location when building graph fix: HTTPNode.Location when building graph Jan 24, 2025
Copy link
Member

@vmaerten vmaerten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks

Indeed, when no filename is provided, the node.URL is inconsistent, which causes issues with the graph.

@jeongukjae
Copy link
Contributor Author

@vmaerten Hi! thanks for reviewing! could you merge this one please?

@pd93 pd93 merged commit edbb83f into go-task:main Jan 29, 2025
14 checks passed
@pd93
Copy link
Member

pd93 commented Jan 29, 2025

@jeongukjae Thanks! 🚀

@jeongukjae jeongukjae deleted the fix-http-node-vertex-issue branch January 29, 2025 22:48
pd93 added a commit that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants