Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tar_path documentation #184

Merged

Conversation

AlaricWhitney
Copy link
Contributor

tar_path is already an option within the kaniko plugin, but it is undocumented. This PR adds the documentation for it.

go-vela/community#896

@AlaricWhitney AlaricWhitney requested a review from a team as a code owner December 21, 2023 15:23
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (24f2136) 44.91% compared to head (7400678) 44.91%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #184   +/-   ##
=======================================
  Coverage   44.91%   44.91%           
=======================================
  Files           7        7           
  Lines         688      688           
=======================================
  Hits          309      309           
  Misses        379      379           

Copy link
Member

@wass3rw3rk wass3rw3rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! lgtm!

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KellyMerrick KellyMerrick merged commit d6626ba into go-vela:main Dec 21, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants