-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from BatEnum
to Seq
#1443
Open
karoliineh
wants to merge
10
commits into
master
Choose a base branch
from
enum-to-seq
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What is still missing here? |
A new batteries release would allot switching many |
Batteries 3.9.0 has now been released, so that should allow porting some of the previously problematic places as well. |
karoliineh
force-pushed
the
enum-to-seq
branch
from
January 22, 2025 14:01
6388252
to
fe0608d
Compare
sim642
added
the
pr-dependency
Depends or builds on another PR, which should be merged before
label
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cleanup
Refactoring, clean-up
pr-dependency
Depends or builds on another PR, which should be merged before
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A try on switching to the more standard
Seq.t
inEnum
instances where possible as proposed in #1437Some things that I noticed:
Enum.cartesian_product
is calledproduct
inSeq
Enum.uncombine
is calledunzip
(orsplit
) inSeq
Enum.fold
is calledfold_left
inSeq
Enum.uniq
inSeq
to_seq
inBatHashtbl
to_seq_keys
inBatHashtbl
as in the Ocaml standard libraryHashtbl
TODO
Seq
functions are that new. (Bump OCaml lower bound to 4.14 #1448)