Define data type hints for base plugin methods

godaddy-wordpress · Oct 10, 2024 · 429387a · 429387a
1 parent aedb000
commit 429387a
Show file tree

Hide file tree

Showing 4 changed files with 192 additions and 202 deletions.
diff --git a/tests/_support/plugins/gateway-test-plugin/includes/Plugin.php b/tests/_support/plugins/gateway-test-plugin/includes/Plugin.php
@@ -46,26 +46,26 @@ public function __construct() {
 	}
 
 
-	public function get_documentation_url() {
-
+	public function get_documentation_url() : ?string
+	{
 		return 'https://example.com';
 	}
 
 
-	public function get_settings_url( $plugin_id = null ) {
-
+	public function get_settings_url( string $plugin_id = null ) : string
+	{
 		return admin_url( 'admin.php?page=wc-settings' );
 	}
 
 
-	public function get_plugin_name() {
-
+	public function get_plugin_name() : string
+	{
 		return 'Framework Gateway Test Plugin';
 	}
 
 
-	protected function get_file() {
-
+	protected function get_file() : string
+	{
 		return __DIR__;
 	}
 

diff --git a/tests/_support/plugins/test-plugin/includes/Plugin.php b/tests/_support/plugins/test-plugin/includes/Plugin.php
@@ -45,26 +45,26 @@ public function __construct() {
 	}
 
 
-	public function get_documentation_url() {
-
+	public function get_documentation_url() : ?string
+	{
 		return 'https://example.com';
 	}
 
 
-	public function get_settings_url( $plugin_id = null ) {
-
+	public function get_settings_url( string $plugin_id = null ) : string
+	{
 		return admin_url( 'admin.php?page=wc-settings' );
 	}
 
 
-	public function get_plugin_name() {
-
+	public function get_plugin_name() : string
+	{
 		return 'Plugin Framework Test';
 	}
 
 
-	protected function get_file() {
-
+	protected function get_file() : string
+	{
 		return __DIR__;
 	}