Make subs active/ver functions filterable

woocommerce/class-sv-wc-plugin-compatibility.php

@@ -324,22 +324,31 @@ public static function is_wc_subscriptions_version_lt( $version ) {
 	 */
 	protected static function get_wc_subscriptions_version() : ?string {
 
+		$version = null;
+
 		if ( class_exists( 'WC_Subscriptions' ) && ! empty( \WC_Subscriptions::$version ) ) {
-			return \WC_Subscriptions::$version;
+			$version = \WC_Subscriptions::$version;
 		}
 
-		if ( class_exists( 'WC_Subscriptions_Core_Plugin' ) ) {
+		if ( ! $version && class_exists( 'WC_Subscriptions_Core_Plugin' ) ) {
 			 if ( is_callable( [ \WC_Subscriptions_Core_Plugin::class, 'instance' ] ) ) {
 
 				 $instance = \WC_Subscriptions_Core_Plugin::instance();
 
 				 if ( is_object( $instance ) && method_exists( $instance, 'get_library_version' ) ) {
-					 return $instance->get_library_version();
+					 $version = $instance->get_library_version();
 				 }
 			 }
 		}
 
-		return null;
+		/**
+		 * Filters the WooCommerce Subscriptions version when fetched by the framework.
+		 *
+		 * This accounts for cases where the version is not found by the framework as Subscriptions may be embedded as a core library by third party code.
+		 *
+		 * @param string $version WooCommerce Subscriptions version
+		 */
+		return (string) apply_filters( 'sv_wc_plugin_framework_wc_subscriptions_version', $version );
 	}
 
 

woocommerce/payment-gateway/class-sv-wc-payment-gateway-plugin.php

@@ -1358,7 +1358,7 @@ public function get_accepted_currencies() {
 
 
 	/**
-	 * Checks is WooCommerce Subscriptions is active
+	 * Checks is WooCommerce Subscriptions is active as a plugin or as a core library
 	 *
 	 * @since 1.0.0
 	 *
@@ -1370,7 +1370,16 @@ public function is_subscriptions_active() : bool {
 			return $this->subscriptions_active;
 		}
 
-		return $this->subscriptions_active = class_exists( 'WC_Subscriptions_Core_Plugin' ) || $this->is_plugin_active( 'woocommerce-subscriptions.php' );
+		$this->subscriptions_active = class_exists( 'WC_Subscriptions_Core_Plugin' ) || $this->is_plugin_active( 'woocommerce-subscriptions.php' );
+
+		/**
+		 * Filters whether WooCommerce Subscriptions is active.
+		 *
+		 * This future proofs the plugin for when WooCommerce Subscriptions is included as a core library or third party plugin embedding the core library.
+		 *
+		 * @param bool $subscriptions_active
+		 */
+		return apply_filters( 'sv_wc_payment_gateway_is_subscriptions_active', $this->subscriptions_active );
 	}