Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024 in review blogpost #985

Merged
merged 47 commits into from
Jan 28, 2025
Merged

Conversation

MurderVeggie
Copy link
Collaborator

@MurderVeggie MurderVeggie commented Dec 29, 2024

CC @coppolaemilio

Still TODO:

  • add cover image

Copy link
Contributor

@paddy-exe paddy-exe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Haven't found much else going through the text

collections/_article/year-in-review-2024.md Outdated Show resolved Hide resolved
collections/_article/year-in-review-2024.md Outdated Show resolved Hide resolved
Co-authored-by: Patrick Exner (FlameLizard) <[email protected]>
collections/_article/year-in-review-2024.md Outdated Show resolved Hide resolved
collections/_article/year-in-review-2024.md Outdated Show resolved Hide resolved
collections/_article/year-in-review-2024.md Outdated Show resolved Hide resolved
collections/_article/year-in-review-2024.md Outdated Show resolved Hide resolved
collections/_article/year-in-review-2024.md Outdated Show resolved Hide resolved
collections/_article/year-in-review-2024.md Outdated Show resolved Hide resolved
collections/_article/year-in-review-2024.md Outdated Show resolved Hide resolved
collections/_article/year-in-review-2024.md Outdated Show resolved Hide resolved
collections/_article/year-in-review-2024.md Outdated Show resolved Hide resolved
collections/_article/year-in-review-2024.md Outdated Show resolved Hide resolved
@MurderVeggie
Copy link
Collaborator Author

@JohnVeness thanks for the in-depth review!

Copy link
Member

@coppolaemilio coppolaemilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments. I think it still needs some work and maybe the scope of it is too big.

collections/_article/year-in-review-2024.md Outdated Show resolved Hide resolved
collections/_article/year-in-review-2024.md Outdated Show resolved Hide resolved
collections/_article/year-in-review-2024.md Outdated Show resolved Hide resolved
collections/_article/year-in-review-2024.md Outdated Show resolved Hide resolved
collections/_article/year-in-review-2024.md Outdated Show resolved Hide resolved
collections/_article/year-in-review-2024.md Outdated Show resolved Hide resolved
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the concept of "we picked one per month" / "one per technical area" needs to be better introduced (made a suggestion for the technical part), as otherwise it reads a bit like this is a summary of our key achievements this year, when it's mostly about picking one cool thing for each month.

If it was a summary of the key achievements, it would be 90% technological highlights (which is what we spend most of our efforts on) from 4.3 and 4.4-beta1.

But I still think this can work with a bit of tweaking.

collections/_article/year-in-review-2024.md Outdated Show resolved Hide resolved
collections/_article/year-in-review-2024.md Outdated Show resolved Hide resolved
MurderVeggie and others added 3 commits January 20, 2025 11:12
cherry picks instead of trying to be all-encompassing
doubled up on the newsletter CTA
@Calinou Calinou added the topic:blog New blogposts and corrections label Jan 20, 2025
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

collections/_article/year-in-review-2024.md Outdated Show resolved Hide resolved
collections/_article/year-in-review-2024.md Outdated Show resolved Hide resolved
collections/_article/year-in-review-2024.md Outdated Show resolved Hide resolved
blue cherries because why not
@coppolaemilio
Copy link
Member

Hopefully the last round of edits:

  • The name of the file needs to change from year-in-review-2024.md to 2024-cherry-picks.md
  • The category is set to newsletter but should be showcase. I wouldn't bundle the newsletter entries with the regular rss feed.
  • Date needs to be edited to the 24th which is when it will probably go out
  • To follow the structure of the lists like Platforms and Systems, I would group the lists that only have one item (2D, 3D, Core, Editor, and Documentation) into a list called something like "General" and follow the same structure as the other lists: "sub category title: link"

After those changes I can embed the html form so that people can sign up to the newsletter from there instead of having to visit the form first.

as per emis feedback
@MurderVeggie
Copy link
Collaborator Author

Hopefully the last round of edits:

* The name of the file needs to change from `year-in-review-2024.md` to `2024-cherry-picks.md`

* The category is set to `newsletter` but should be `showcase`. I wouldn't bundle the newsletter entries with the regular rss feed.

* Date needs to be edited to the 24th which is when it will probably go out

* To follow the structure of the lists like Platforms and Systems, I would group the lists that only have one item (2D, 3D, Core, Editor, and Documentation) into a list called something like "General" and follow the same structure as the other lists: "sub category title: link"

After those changes I can embed the html form so that people can sign up to the newsletter from there instead of having to visit the form first.

Done - as a side note, the previous structure was based on the teams page, we might want to add the "General" headline there as well then to keep it consistent.

@coppolaemilio coppolaemilio merged commit 15a2c90 into godotengine:master Jan 28, 2025
1 check passed
@coppolaemilio
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:blog New blogposts and corrections
Projects
None yet
Development

Successfully merging this pull request may close these issues.