bump pkg´s

[ReneWerner87]

Summary by CodeRabbit

• Bug Fixes
  • Improved string conversion method when setting values in storage
  • Optimized byte slice to string conversion in multiple storage implementations

The changes appear to be a minor optimization in string conversion techniques across different storage interfaces, which should provide more direct and potentially more efficient string handling.

[coderabbitai]

Walkthrough

The pull request introduces a minor modification to the Set method in two separate files: rueidis/rueidis.go and valkey/valkey.go. The primary change involves replacing the utils.ToString(val) conversion method with a direct string(val) type conversion when handling byte slice values. This change occurs in both conditional branches of the method (when expiration is greater than zero and when it is not). The core logic and method signature remain unchanged, ensuring consistent behavior of the storage operations.

Changes

File	Change Summary
rueidis/rueidis.go	Replaced utils.ToString(val) with string(val) in Set method
valkey/valkey.go	Replaced utils.ToString(val) with string(val) in Set method

Possibly related PRs

• 🔥 Feature: Add valkey driver #1538: Changes to the Set method in Storage struct, replacing utils.ToString(val) with string(val)

Suggested reviewers

• sixcolors
• gaby

Poem

🐰 Bytes to strings, a simple dance,
No utils needed, just a glance
string(val) takes the stage
Conversion clean, turn the page
A rabbit's code, swift and bright! 🚀

Finishing Touches

• 📝 Generate Docstrings (Beta)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

rueidis/rueidis.go (1)

106-106: LGTM! Consistent with changes in valkey/valkey.go.

The optimization is correctly applied here as well, maintaining consistency across both implementations.

Consider extracting the common storage implementation into a shared base struct to reduce code duplication between valkey/valkey.go and rueidis/rueidis.go. This would make future maintenance easier and ensure consistent behavior across implementations.

Example approach:

// common/storage.go
type BaseStorage struct {
    // Common fields and methods
}

func (s *BaseStorage) Set(key string, val []byte, exp time.Duration) error {
    if len(key) <= 0 || len(val) <= 0 {
        return nil
    }
    return s.doSet(key, val, exp) // Implementation provided by concrete types
}

Also applies to: 108-108

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3bfea34 and f01f10c.

⛔ Files ignored due to path filters (6)

• .github/workflows/golangci-lint.yml is excluded by !**/*.yml
• go.mod is excluded by !**/*.mod
• rueidis/go.mod is excluded by !**/*.mod
• rueidis/go.sum is excluded by !**/*.sum, !**/*.sum
• valkey/go.mod is excluded by !**/*.mod
• valkey/go.sum is excluded by !**/*.sum, !**/*.sum

📒 Files selected for processing (2)

• rueidis/rueidis.go (1 hunks)
• valkey/valkey.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Compare

🔇 Additional comments (2)

valkey/valkey.go (1)

106-106: LGTM! Performance improvement through direct type conversion.

The change from utils.ToString(val) to string(val) is a good optimization. Direct type conversion is more efficient as it avoids the function call overhead while maintaining the same safety guarantees. This is also more idiomatic Go code.

Also applies to: 108-108

rueidis/rueidis.go (1)

106-108: PR title doesn't match the actual changes.

The PR title "bump pkg's" suggests package version updates, but the changes are actually code optimizations replacing utils.ToString(val) with direct string(val) conversion. Consider updating the PR title to better reflect the actual changes, e.g., "perf: optimize string conversion in Set methods".

Let's check if there are any package version updates in the repository: