refactor: refactor metric handling by removing IncCompletedTask method

- Remove `IncCompletedTask` method from `Metric` interface
- Remove `completedTasks` field from `metric` struct
- Remove `IncCompletedTask` method implementation
- Update `CompletedTasks` method to return the sum of `successTasks` and `failureTasks`
- Remove call to `IncCompletedTask` in `Queue`'s `work` method

Signed-off-by: appleboy <[email protected]>

metric.go

@@ -14,7 +14,6 @@ type Metric interface {
 	IncSuccessTask()
 	IncFailureTask()
 	IncSubmittedTask()
-	IncCompletedTask()
 }
 
 var _ Metric = (*metric)(nil)
@@ -24,7 +23,6 @@ type metric struct {
 	successTasks   uint64
 	failureTasks   uint64
 	submittedTasks uint64
-	completedTasks uint64
 }
 
 // NewMetric for default metric structure
@@ -56,10 +54,6 @@ func (m *metric) IncSubmittedTask() {
 	atomic.AddUint64(&m.submittedTasks, 1)
 }
 
-func (m *metric) IncCompletedTask() {
-	atomic.AddUint64(&m.completedTasks, 1)
-}
-
 func (m *metric) SuccessTasks() uint64 {
 	return atomic.LoadUint64(&m.successTasks)
 }
@@ -73,5 +67,5 @@ func (m *metric) SubmittedTasks() uint64 {
 }
 
 func (m *metric) CompletedTasks() uint64 {
-	return atomic.LoadUint64(&m.completedTasks)
+	return atomic.LoadUint64(&m.successTasks) + atomic.LoadUint64(&m.failureTasks)
 }

queue.go

@@ -172,7 +172,6 @@ func (q *Queue) work(task core.TaskMessage) {
 		if q.afterFn != nil {
 			q.afterFn()
 		}
-		q.metric.IncCompletedTask()
 	}()
 
 	if err = q.run(task); err != nil {