This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
travis.yml, hack: fix tests on tip #2097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tip tests were failing due to the lack of a GOCACHE environment variable, and bad defaults in tests where home directories did not exist. Fix these by setting the GOCACHE to a place we know exists. This and the Xenial fix combined allow us to re-enable the test suite, e.g. to permit failures in the test suite to actually fail the build. (We may still want to address the GOCACHE tests locally for users that do not have a GOCACHE environment variable set; as it stands, they still fail.)
jmank88
approved these changes
Jan 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tip tests were failing due to the lack of a GOCACHE environment
variable, and bad defaults in tests where home directories did not
exist. Fix these by setting the GOCACHE to a place we know exists.
This and the Xenial fix combined allow us to re-enable the test suite,
e.g. to permit failures in the test suite to actually fail the build.
(We may still want to address the GOCACHE tests locally for users that
do not have a GOCACHE environment variable set; as it stands, they
still fail.)
Fixes #2089.
Fixes #2071.