fix: create route failure (#2077)

Signed-off-by: 张启航 <[email protected]>
goodrain · Nov 21, 2024 · 848c9d5 · 848c9d5
1 parent f7469f7
commit 848c9d5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/api/controller/apigateway/api_gateway_route.go b/api/controller/apigateway/api_gateway_route.go
@@ -248,8 +248,8 @@ func (g Struct) CreateHTTPAPIRoute(w http.ResponseWriter, r *http.Request) {
 	}, v1.CreateOptions{})
 	if err == nil {
 		name := r.URL.Query().Get("name")
-		name = name[1:]
 		if name != "" {
+			name = name[1:]
 			err = c.ApisixRoutes(tenant.Namespace).Delete(r.Context(), name, v1.DeleteOptions{})
 			if err != nil {
 				logrus.Errorf("delete route %v failure: %v", name, err)

diff --git a/builder/sources/registry/registry.go b/builder/sources/registry/registry.go
@@ -129,7 +129,7 @@ func newFromTransport(registryURL, username, password string, transport http.Rou
 	}
 
 	if err := registry.Ping(); err != nil {
-		if errors.Is(err, ErrRegistryNotFound) && !containsScheme {
+		if err != nil {
 			// try again with http url
 			registry.URL = strings.Replace(url, "https", "http", 1)
 			if err := registry.Ping(); err != nil {