Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of docstrings to the files #61

Merged
merged 7 commits into from
Aug 30, 2023

Conversation

rajveer43
Copy link
Contributor

close #60

@rajveer43 rajveer43 requested a review from a team as a code owner August 28, 2023 14:56
@github-actions github-actions bot added the status:awaiting review PR awaiting review from a maintainer label Aug 28, 2023
Copy link
Collaborator

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for taking the time to send a PR!

This mostly looks good, I just fixed some formatting in the first file, could you fix the couple of comments in the other two?

google/generativeai/models.py Outdated Show resolved Hide resolved
google/generativeai/models.py Outdated Show resolved Hide resolved
@@ -63,6 +91,21 @@ def _next_page(self):


def _list_models(page_size, page_token, client):
"""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too

google/generativeai/models.py Outdated Show resolved Hide resolved
google/generativeai/text.py Outdated Show resolved Hide resolved
@rajveer43
Copy link
Contributor Author

rajveer43 commented Aug 29, 2023

@MarkDaoust, Sure I will update it as per your guidance and black command for formatting this is black . right?

@MarkDaoust MarkDaoust force-pushed the docs-update branch 3 times, most recently from 6d057a7 to 181c956 Compare August 30, 2023 18:42
@MarkDaoust
Copy link
Collaborator

That should work this time.

@MarkDaoust
Copy link
Collaborator

Thanks!

@MarkDaoust MarkDaoust merged commit 837d237 into google-gemini:main Aug 30, 2023
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Aug 30, 2023
markmcd pushed a commit to markmcd/generative-ai-python that referenced this pull request Oct 30, 2023
* update model.py

* more

* Add back-ticks, remove some redundant types.

* update model.py 1

* fomatting

* update text.py

* Formatting fixes

---------

Co-authored-by: Mark Daoust <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more docstrings.
3 participants