Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Update: Retry logic for the ee.data.computePixels update. #151

Merged
merged 12 commits into from
Mar 15, 2024

Conversation

dabhicusp
Copy link
Collaborator

Xee always used the default value of the max_retries, initial_delay while calling the ee.data.computePixels() through the robust_getitem which affects the QPS(queries per second). To provide Xee users with more control over the QPS, these two variables are now configurable within Xee and can be set by users as well.

xee/ext.py Outdated Show resolved Hide resolved
xee/ext.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@mahrsee1997 mahrsee1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@naschmitz naschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a unit test to verify the kwargs are passed through correctly?

xee/ext.py Outdated Show resolved Hide resolved
xee/ext.py Outdated Show resolved Hide resolved
xee/ext.py Outdated Show resolved Hide resolved
xee/ext.py Outdated Show resolved Hide resolved
xee/ext.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@mahrsee1997 mahrsee1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

xee/ext.py Outdated Show resolved Hide resolved
xee/ext.py Outdated Show resolved Hide resolved
xee/ext.py Outdated Show resolved Hide resolved
xee/ext.py Outdated Show resolved Hide resolved
xee/ext.py Show resolved Hide resolved
xee/ext.py Outdated Show resolved Hide resolved
@copybara-service copybara-service bot merged commit f071724 into main Mar 15, 2024
11 checks passed
@dabhicusp dabhicusp deleted the improve_retry_logic branch March 15, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants